Review the go-proxy from Improbable team

[wenbozhu]

1. spec compliance, as we are implementing the new grpc-web spec in nginx at the same time
2. feature parity, e.g. CORS, URL white-listing
3. discuss when/whether to add this proxy to grpc-contrib, in addition to the existing go-gateway, e.g. does the proxy support non-grpc-web features etc?

https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb

@zinuga
@mwitkow

[mwitkow]

So basically we internally have a combination of:
https://github.com/mwitkow/grpc-proxy (a transparent gRPC go proxy)
and
https://github.com/improbable-eng/grpc-web/tree/master/go

I think we can build a generic gRPC-Web to gRPC backend proxy written in Go, with automatic SRV discovery from k8s. That's the "I have spare time" plan at least ;)

[wenbozhu]

Thanks. Keep us posted, on future progresses :)

[mwitkow]

@wenbozhu here's an update:
standalone Go binary proxy binary that does what NginX does for gRPC-Web:
https://github.com/improbable-eng/grpc-web/tree/master/go/grpcwebproxy

there's also a Go library that wraps a standard gRPC-Go server and makes it into a gRPC-Web
https://github.com/improbable-eng/grpc-web/tree/master/go/grpcweb

Since the latter is an extended hackery of @bradfitz HTTP2 stack, it would be great if he took a peek :)

[wenbozhu]

Thanks!

We will take a look at the Go implementation.

The 2nd one is interesting! Please ping Brad directly if you need a code review from him.

[pieterlouw]

Hi,
FWIW, I've extended the great work that @mwitkow has done so far and created a plugin for Caddy:
https://github.com/pieterlouw/caddy-grpc

It's been accepted by the Caddy project and will be available for download as part of the 0.10.4 release of Caddy: caddyserver/caddy#1694

Pieter

[mwitkow]

@pieterlouw cool! thanks :)