Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
murgatroid99 committed Mar 13, 2024
1 parent c3e9fbe commit f794b77
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion examples/keepalive/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ node server.js
## Start the client

```
GRPC_TRACE=transport,keepalive GRPC_VERBOSITY=DEBUG client.js
GRPC_TRACE=transport,keepalive GRPC_VERBOSITY=DEBUG node client.js
```
2 changes: 1 addition & 1 deletion examples/keepalive/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const packageDefinition = protoLoader.loadSync(
const echoProto = grpc.loadPackageDefinition(packageDefinition).grpc.examples.echo;

const keepaliveOptions = {
// Ping the client every 10 seconds to ensure the connection is still active
// Ping the server every 10 seconds to ensure the connection is still active
'grpc.keepalive_time_ms': 10_000,
// Wait 1 second for the ping ack before assuming the connection is dead
'grpc.keepalive_timeout_ms': 1_000,
Expand Down

0 comments on commit f794b77

Please sign in to comment.