Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in deprecated blocking stub javadoc. #11772

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

benjaminp
Copy link
Contributor

No description provided.

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You noticed quickly 😄. Have you started playing with the new stub, or you just happened to notice the misspelling in passing?

@ejona86 ejona86 requested a review from larry-safran December 26, 2024 19:24
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 26, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 26, 2024
@benjaminp
Copy link
Contributor Author

I'm trying to use the new stubs. I hope there's a way for servers to do client-streaming RPCS in a blocking way in the works, too?

@larry-safran larry-safran merged commit 8c261c3 into grpc:master Dec 26, 2024
16 checks passed
@ejona86
Copy link
Member

ejona86 commented Dec 26, 2024

Excellent. We'd love to hear feedback about them.

We'd really like to do server-side, but there's some threading challenges. We need to run the service in a separate thread so we can receive onMessage/onReady callbacks. Ideally we'd also like to use the threadless executor for receiving callbacks (so we can avoid additional thread hops). I don't know of anyone that will have time soon to work on it.

@benjaminp benjaminp deleted the stub-typo branch December 26, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants