Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services, xds, orca: LRS named metrics support #10282

Merged
merged 9 commits into from
Jul 11, 2023
Merged

services, xds, orca: LRS named metrics support #10282

merged 9 commits into from
Jul 11, 2023

Conversation

danielzhaotongliu
Copy link
Collaborator

@danielzhaotongliu danielzhaotongliu commented Jun 14, 2023 •
edited
Loading

Design:

@danielzhaotongliu danielzhaotongliu marked this pull request as ready for review June 15, 2023 01:31
@danielzhaotongliu
Copy link
Collaborator Author

PTAL @ejona86. Thanks.

@danielzhaotongliu
Copy link
Collaborator Author

cc @YifeiZhuang

@ran-su ran-su requested review from ejona86 and YifeiZhuang June 20, 2023 22:43
YifeiZhuang
YifeiZhuang reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@YifeiZhuang YifeiZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, overall LGTM.

xds/src/main/java/io/grpc/xds/LoadStatsManager2.java Outdated Show resolved Hide resolved
ejona86
ejona86 reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really have a link to the gRFC, instead of just go links to internal documents. https://github.com/grpc/proposal/blob/master/A64-lrs-custom-metrics.md

xds/src/main/java/io/grpc/xds/LoadStatsManager2.java Outdated Show resolved Hide resolved
xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java Outdated Show resolved Hide resolved
@danielzhaotongliu danielzhaotongliu requested a review from ejona86 July 6, 2023 23:20
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 7, 2023
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 7, 2023
@YifeiZhuang YifeiZhuang added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jul 10, 2023
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jul 10, 2023
@ran-su ran-su added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 11, 2023
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 11, 2023
@YifeiZhuang YifeiZhuang merged commit 4fa2814 into grpc:master Jul 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@YifeiZhuang YifeiZhuang YifeiZhuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danielzhaotongliu @ejona86 @YifeiZhuang @ran-su @grpc-kokoro