examples/features/csm_observability: use helloworld client and server instead of echo client and server #7945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purnesh42H
force-pushed
the
update-opentelemtry-example-to-hew
branch
from
fe9087f to
690c2c1
Compare
arjan-bal
reviewed
Dec 18, 2024
| addr string | ||
| } | ||
|
|
||
| func (s *echoServer) UnaryEcho(_ context.Context, req *pb.EchoRequest) (*pb.EchoResponse, error) { | ||
| return &pb.EchoResponse{Message: fmt.Sprintf("%s (from %s)", req.Message, s.addr)}, nil | ||
| // SayHello implements helloworld.GreeterServer |
There was a problem hiding this comment.
SayHello is a method, it's inaccurate to say that it implements an interface. I believe this comment should be on server instead.
There was a problem hiding this comment.
Actually, this is what we have in every example. I just took it from helloworld and observability example
arjan-bal
reviewed
Dec 18, 2024
yes, i checked the output on server and client and prometheous |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7945 +/- ##
==========================================
- Coverage 82.15% 82.03% -0.12%
==========================================
Files 381 381
Lines 38539 38539
==========================================
- Hits 31660 31615 -45
- Misses 5574 5600 +26
- Partials 1305 1324 +19 |
arjan-bal
approved these changes
Dec 18, 2024
purnesh42H
force-pushed
the
update-opentelemtry-example-to-hew
branch
from
8d08898 to
6db15dc
Compare
purnesh42H
changed the title
purnesh42H
force-pushed
the
update-opentelemtry-example-to-hew
branch
from
b599957 to
127f91c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: