-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/xds: Fix typo in README.md #7921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo
The committers listed above are authorized under a signed CLA. |
@ashupednekar Can you please sign the CLA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7921 +/- ##
==========================================
+ Coverage 82.05% 82.10% +0.04%
==========================================
Files 377 377
Lines 38180 38180
==========================================
+ Hits 31330 31346 +16
+ Misses 5549 5540 -9
+ Partials 1301 1294 -7 |
eshitachandwani
approved these changes
Dec 11, 2024
arjan-bal
added
Type: Documentation
Documentation or examples
Area: xDS
Includes everything xDS related, including LB policies used with xDS.
and removed
Type: Internal Cleanup
Refactors, etc
labels
Dec 11, 2024
arjan-bal
approved these changes
Dec 11, 2024
Thanks for fixing this! |
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: xDS
Includes everything xDS related, including LB policies used with xDS.
Type: Documentation
Documentation or examples
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typo in xds readme, changed
data plan
todata plane
RELEASE NOTES: None