Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/transport: replace hardcoded status codes with http constants #7910

Merged
merged 1 commit into from
Dec 10, 2024
Merged

internal/transport: replace hardcoded status codes with http constants #7910

merged 1 commit into from
Dec 10, 2024

Conversation

JovialYip
Copy link
Contributor

@JovialYip JovialYip commented Dec 8, 2024 •
edited by purnesh42H
Loading

RELEASE NOTES: None

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 8, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (66ba4b2) to head (76b275f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7910      +/-   ##
==========================================
+ Coverage   82.04%   82.11%   +0.06%     
==========================================
  Files         377      377              
  Lines       38180    38180              
==========================================
+ Hits        31326    31352      +26     
+ Misses       5551     5529      -22     
+ Partials     1303     1299       -4
Files with missing lines Coverage Δ
internal/transport/http2_server.go 91.69% <100.00%> (+0.92%) ⬆️

... and 18 files with indirect coverage changes

@eshitachandwani eshitachandwani added the Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. label Dec 9, 2024
@eshitachandwani eshitachandwani added this to the 1.69 Release milestone Dec 9, 2024
@eshitachandwani eshitachandwani self-assigned this Dec 9, 2024
@purnesh42H purnesh42H changed the title refactor: replace hardcoded status codes with http constants internal/transport: replace hardcoded status codes with http constants Dec 9, 2024
@eshitachandwani eshitachandwani self-requested a review December 9, 2024 04:52
@arjan-bal arjan-bal modified the milestones: 1.69 Release, 1.70 Release Dec 10, 2024
@arjan-bal arjan-bal self-assigned this Dec 10, 2024
arjan-bal
arjan-bal approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@arjan-bal arjan-bal merged commit 0027558 into grpc:master Dec 10, 2024
15 checks passed
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Dec 18, 2024
@JovialYip @purnesh42H
internal/transport: replace integer status codes with http constants (g…
1beafbd 
…rpc#7910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshitachandwani eshitachandwani eshitachandwani approved these changes

@arjan-bal arjan-bal arjan-bal approved these changes

@purnesh42H purnesh42H Awaiting requested review from purnesh42H

Assignees

@purnesh42H purnesh42H

@arjan-bal arjan-bal

Labels
Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.70 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@JovialYip @arjan-bal @eshitachandwani @purnesh42H