Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Split import paths for message and service generated code #7891

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

arjan-bal
Copy link
Contributor

This is required to make bazel/blaze build work.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added the Type: Internal Cleanup Refactors, etc label Dec 3, 2024
@arjan-bal arjan-bal added this to the 1.69 Release milestone Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.96%. Comparing base (78aa51b) to head (55aa5f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7891      +/-   ##
==========================================
- Coverage   82.01%   81.96%   -0.06%     
==========================================
  Files         377      377              
  Lines       38117    38117              
==========================================
- Hits        31263    31243      -20     
- Misses       5556     5566      +10     
- Partials     1298     1308      +10     

see 24 files with indirect coverage changes

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purnesh42H
Copy link
Contributor

May be we should add the vet rule?

@purnesh42H purnesh42H assigned arjan-bal and unassigned purnesh42H Dec 3, 2024
@arjan-bal
Copy link
Contributor Author

May be we should add the vet rule?

We can discuss this offline, with other maintainers.

@arjan-bal arjan-bal merged commit 634497b into grpc:master Dec 3, 2024
15 checks passed
misvivek added a commit to misvivek/grpc-go that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants