Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick pr 7571 #7611

Closed
wants to merge 2 commits into from
Closed

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Sep 10, 2024

Fixes: #7572

RELEASE NOTES: None

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (973e3dc) to head (eaf704f).
Report is 3 commits behind head on v1.66.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.66.x    #7611      +/-   ##
===========================================
- Coverage    81.86%   81.77%   -0.09%     
===========================================
  Files          361      361              
  Lines        27858    27859       +1     
===========================================
- Hits         22805    22781      -24     
- Misses        3855     3872      +17     
- Partials      1198     1206       +8     
Files with missing lines Coverage Δ
mem/buffer_slice.go 96.20% <ø> (ø)
server.go 81.85% <100.00%> (-0.28%) ⬇️

... and 20 files with indirect coverage changes

@arjan-bal
Copy link
Contributor

Please update the version in the release branch to 1.66.2-dev before merging.

@easwars
Copy link
Contributor

easwars commented Sep 10, 2024

Also, please change the PR title to include the release branch into which we are cherry picking. See here for an example: #7019

@easwars
Copy link
Contributor

easwars commented Sep 10, 2024

Is there a reason to include the commit to change the version along with the other commit that you are cherry picking?

@purnesh42H purnesh42H closed this Sep 11, 2024
@purnesh42H purnesh42H deleted the cherry-pick-pr-7571 branch September 11, 2024 06:28
@purnesh42H
Copy link
Contributor Author

Is there a reason to include the commit to change the version along with the other commit that you are cherry picking?

yeah that was a mistake of checking out from previous patch release branch. I have created a separate PR

@arjan-bal
Copy link
Contributor

FYI: This is the PR that will be merged: #7616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants