Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop/lb: Increase Go PSM LB test timeout to 300min #7393

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

sreenithi
Copy link
Contributor

@sreenithi sreenithi commented Jul 5, 2024

Increased timeout of the LB test suite to 5 hours

Reason for increase:
The LB test suite (xds_k8s_lb tests) have been failing with a 3 hour timeout over the past 2 weeks, with the following error message: Aborting VM command due to timeout of 10800 seconds

This error was also observed for other gRPC languages like Java, Python and Node, and similar PRs have been raised in the respective language repos.

RELEASE NOTES: None

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (bdd707e) to head (75b7787).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7393      +/-   ##
==========================================
- Coverage   81.42%   81.36%   -0.06%     
==========================================
  Files         348      348              
  Lines       26744    26744              
==========================================
- Hits        21775    21759      -16     
- Misses       3779     3788       +9     
- Partials     1190     1197       +7     

see 14 files with indirect coverage changes

@arjan-bal
Copy link
Contributor

@sreenithi can you mention the reasoning behind the change in the PR description for future reference?

Also is there someone among the maintainers who's familiar with the issue at hand who I can add assign as the reviewer?

@purnesh42H
Copy link
Contributor

purnesh42H commented Jul 5, 2024

Is the same change done to increase for all the languages?

@sreenithi
Copy link
Contributor Author

@arjan-bal The LB test suite (xds_k8s_lb) have been failing with a 3 hour timeout over the past 2 weeks, with the following error message: Aborting VM command due to timeout of 10800 seconds.
So Sergii suggested to increase the timeout of the tests.

And I'm not sure of the relevant maintainer, possibly Arvind or Doug, whoever also knows about the PSM Interop tests should be a good choice.

@sreenithi
Copy link
Contributor Author

@purnesh42H This change is specific to Go, but I've raised separate PRs in the respective repos for Java and Python as well.

@purnesh42H
Copy link
Contributor

@purnesh42H This change is specific to Go, but I've raised separate PRs in the respective repos for Java and Python as well.

oh yeah i meant if you are changing for all languages. Can mention the languages in description. I don't think we should link internal issues here

@sreenithi
Copy link
Contributor Author

ok, I have updated the PR comment as you suggested.

@purnesh42H
Copy link
Contributor

nit: pr title can be test: increase psm-interop-test timeout to 300m from 180m. Also, might be good to link the PRs of java and python here for reference

Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindbr8 arvindbr8 added this to the 1.66 Release milestone Jul 8, 2024
@arvindbr8 arvindbr8 changed the title [LB] Increase Go PSM LB test timeout to 300min interop/lb: Increase Go PSM LB test timeout to 300min Jul 8, 2024
@arvindbr8 arvindbr8 merged commit 53a5c41 into grpc:master Jul 8, 2024
13 checks passed
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 11, 2024
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants