-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interop/lb: Increase Go PSM LB test timeout to 300min #7393
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7393 +/- ##
==========================================
- Coverage 81.42% 81.36% -0.06%
==========================================
Files 348 348
Lines 26744 26744
==========================================
- Hits 21775 21759 -16
- Misses 3779 3788 +9
- Partials 1190 1197 +7 |
@sreenithi can you mention the reasoning behind the change in the PR description for future reference? Also is there someone among the maintainers who's familiar with the issue at hand who I can add assign as the reviewer? |
Is the same change done to increase for all the languages? |
@arjan-bal The LB test suite (xds_k8s_lb) have been failing with a 3 hour timeout over the past 2 weeks, with the following error message: And I'm not sure of the relevant maintainer, possibly Arvind or Doug, whoever also knows about the PSM Interop tests should be a good choice. |
@purnesh42H This change is specific to Go, but I've raised separate PRs in the respective repos for Java and Python as well. |
oh yeah i meant if you are changing for all languages. Can mention the languages in description. I don't think we should link internal issues here |
ok, I have updated the PR comment as you suggested. |
nit: pr title can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Increased timeout of the LB test suite to 5 hours
Reason for increase:
The LB test suite (xds_k8s_lb tests) have been failing with a 3 hour timeout over the past 2 weeks, with the following error message:
Aborting VM command due to timeout of 10800 seconds
This error was also observed for other gRPC languages like Java, Python and Node, and similar PRs have been raised in the respective language repos.
RELEASE NOTES: None