Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats/opentelemetry: Add OpenTelemetry instrumentation component #7166
stats/opentelemetry: Add OpenTelemetry instrumentation component #7166
Changes from 1 commit
47c711e
cb1b2fc
dfc6cda
2f5d482
ee875e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we implement a
nop
version of all these metric types and put them into the struct when the metric is disabled so we don't need all these specialnil
checks? Maybe some already exist in otel?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember having discussions with Yash last year with respect to this performance wise since it's on the RPC path. I think the argument is that a function call is much slower than a branch (who knows, maybe the compiler will inline)? Do you agree or disagree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be an indirect call, so an extra load and a call/return, too. I wouldn't worry about that and optimize for the way you want the code to look. This would not be measurable next to everything else, probably. If you disabled all the metrics (why? wouldn't you disable the recorder instead?), I'd assume the difference in performance between the two approaches would still be negligible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine behavior wise. You can check the implementation to make sure there are no locks being taken.