Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channelz: refactor to move proto API to a separate package #7065

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Mar 26, 2024

I am very very sorry @Clement-Jean - this change will conflict heavily with #7059, but is needed to have a stable API (for an external dependency) that doesn't require the channelz service itself. I can help resolve the conflicts it creates if it's too much work.

RELEASE NOTES: none

@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Mar 26, 2024
@dfawley dfawley added this to the 1.64 Release milestone Mar 26, 2024
@dfawley dfawley requested a review from arvindbr8 March 26, 2024 17:25
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #7065 (1c8b93e) into master (b78c0eb) will decrease coverage by 0.12%.
The diff coverage is 82.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7065      +/-   ##
==========================================
- Coverage   82.53%   82.41%   -0.12%     
==========================================
  Files         300      305       +5     
  Lines       31357    31383      +26     
==========================================
- Hits        25881    25865      -16     
- Misses       4425     4453      +28     
- Partials     1051     1065      +14     
Files Coverage Δ
channelz/internal/protoconv/sockopt_linux.go 85.88% <ø> (ø)
channelz/internal/protoconv/util.go 100.00% <100.00%> (ø)
channelz/internal/protoconv/subchannel.go 89.28% <89.28%> (ø)
channelz/internal/protoconv/server.go 71.87% <71.87%> (ø)
channelz/internal/protoconv/socket.go 89.15% <89.15%> (ø)
channelz/service/service.go 64.28% <54.16%> (-22.12%) ⬇️
channelz/internal/protoconv/channel.go 86.04% <86.04%> (ø)

... and 19 files with indirect coverage changes

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Mar 26, 2024
@dfawley dfawley merged commit fc3f327 into grpc:master Mar 26, 2024
14 checks passed
@Clement-Jean
Copy link
Contributor

@dfawley No worries, I'll try to resolve them first.

@dfawley dfawley deleted the czproto branch May 3, 2024 17:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants