-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: error message using correct keepalive config value #7038
Conversation
`kpTimeoutLeft` is calculated from `kp.Timeout`, but the error message implies it's based on `kp.Time`.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7038 +/- ##
==========================================
+ Coverage 82.44% 82.48% +0.04%
==========================================
Files 296 296
Lines 31475 31475
==========================================
+ Hits 25948 25962 +14
+ Misses 4471 4456 -15
- Partials 1056 1057 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you will need to sign off on the CLAs (by clicking the links from the comment from the bot). Thanks!
@dfawley Talking to my company about it now; it will probably be a couple of weeks because this fix isn't actually particularly high-priority. (I should have just opened a ticket, since the fix is so trivial...) |
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
I will be discussing the CLA with the appropriate person at my company on April 2nd. |
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
@BatmanAoD -- Did your meeting happen? Hopefully it went well. |
@arvindbr8 It sounds like the CLA shouldn't be a problem for us; I've started the signature process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, now we can see more PR's from you @BatmanAoD :) . Thanks so much for the PR!
kpTimeoutLeft
is calculated fromkp.Timeout
, but the error message implies it's based onkp.Time
.RELEASE NOTES: