removing Roots deprecated Subjects field in tests

[miledxz]

Regarding this issue, #6782

one of the goals was to remove usage of deprecated field Subjects, which is not being returned by SystemCertPool anymore, more details here https://pkg.go.dev/crypto/x509#CertPool.Subjects
also I have updated these tests so we compare got and wanted CertPool structs, by using https://pkg.go.dev/crypto/x509#CertPool.Equal

RELEASE NOTES: none

[codecov]

Codecov Report

Merging #6907 (b11a0bd) into master (953d12a) will decrease coverage by 0.19%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6907      +/-   ##
==========================================
- Coverage   83.72%   83.53%   -0.19%     
==========================================
  Files         287      287              
  Lines       30835    30835              
==========================================
- Hits        25816    25759      -57     
- Misses       3964     4010      +46     
- Partials     1055     1066      +11     

see 19 files with indirect coverage changes

[arvindbr8]

LGTM. Thanks for the PR. We need another maintainer's review before we can check this in. cc: @ginayeh could you please take a look at this?

[miledxz]

Heey @arvindbr8 , thanks for reply, as I see everyone is on vacation and you are in charge now hehe, cheers !
btw I can also update comments in tests

[miledxz]

@arvindbr8 , I had just removed unneeded comments, where Subjects are mentioned, that are not used anymore
and cmp that is not used anymore,

I suppose there's no need for comments since its obvious from Equal what are we doing, similar to code above in same files, where Equal is only used without additional explanation,

I can still update and change this if you want

[arvindbr8]

Thanks! The updates made to the comments LGTM

However, I think we remove corresponding ignores of those usages in vet.sh. Could you please append your PR with that?

[arvindbr8]

Marking this PR as fixing #6782 since the other half of the issue was already fixed by you @zedGGs

[miledxz]

@arvindbr8 I have updated pr, but not sure is this still okey ? since vet-proto is not passing in pipeline,

btw I added small update on vet-proto

this: 872cc34,
was not applied here: https://github.com/grpc/grpc-go/blob/master/binarylog/grpc_binarylog_v1/binarylog.pb.go#L433

[arvindbr8]

Overall the changes looks good to me. Please address that one comment about the pb.go file

btw I added small update on vet-proto

We should not be doing that as part of this change. I have actually merged a change to update the pb.go file. Please rollback that file and rebase from master -- and vet-proto should be happy :)

[arvindbr8]

Please roll this back

[miledxz]

thank you for the reivew @arvindbr8 , I have updated pr but tests seems not to pass Im not sure is that because of flakines with xds tests : https://github.com/grpc/grpc-go/actions/runs/7498064395/job/20412613973

I apologise, I have managed somehow to have push from wrong account, I
if this matters I can add separated pr for this,

but I have fixed that too now with proper rebase and commits update so everything is good

[arvindbr8]

Thanks, this looks good to me. cc'ing @ginayeh for a second pass