Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding: fix mention of DecompressedSize in docstring #6665

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Sep 26, 2023

Fixes #6618

RELEASE NOTES: none

@easwars easwars requested a review from dfawley September 26, 2023 19:18
@easwars easwars added the Type: Documentation Documentation or examples label Sep 26, 2023
@easwars easwars added this to the 1.59 Release milestone Sep 26, 2023
Comment on lines +42 to +44
// If a Compressor implements `DecompressedSize(compressedBytes []byte) int`,
// gRPC will invoke it to determine the size of the buffer allocated for the
// result of decompression. A return value of -1 indicates unknown size.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this whole package is experimental, so the extra-extra experimental wouldn't make any sense...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's why I got rid of it.

@dfawley dfawley assigned easwars and unassigned dfawley Sep 26, 2023
@easwars easwars merged commit ee4b62c into grpc:master Sep 26, 2023
1 check passed
@easwars easwars deleted the encoding_docstring_cleanup branch September 26, 2023 21:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encoding: cleanup up docstrings in Compressor interface around DecompressedSize
2 participants