Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/balancergroup: remove usage of UpdateSubConnState #6528

Merged
merged 1 commit into from
Aug 10, 2023
Merged

internal/balancergroup: remove usage of UpdateSubConnState #6528

merged 1 commit into from
Aug 10, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 9, 2023

All of balancergroup's children use StateListener, so we can delete the fallback code that handles ones that don't.

RELEASE NOTES: none

@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Aug 9, 2023
@dfawley dfawley added this to the 1.58 Release milestone Aug 9, 2023
@dfawley dfawley requested a review from easwars August 9, 2023 20:41
@easwars easwars assigned dfawley and unassigned easwars Aug 10, 2023
@dfawley dfawley merged commit ebc3c51 into grpc:master Aug 10, 2023
1 check passed
@dfawley dfawley deleted the uscs_balancergroup branch August 10, 2023 19:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

Assignees

@dfawley dfawley

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.58 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @easwars