-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns: do not call NewServiceConfig when lookups are disabled #3201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @dfawley and @menghanl)
internal/resolver/dns/dns_resolver_test.go, line 614 at r1 (raw file):
var r []string for i := 0; i < len(b); i += txtBytesLimit {
Copy copy the comment with the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dfawley)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @menghanl)
internal/resolver/dns/dns_resolver_test.go, line 614 at r1 (raw file):
Previously, menghanl (Menghan Li) wrote…
Copy copy the comment with the code?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Also:
NewServiceConfig
calls inresolver_conn_wrapper
dns_resolver_test
to actually test service configs, and a handful of cleanupsFixes #3199
This change is