transport: call Unlock in defer to avoid data race #2953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Among 8 read/write operations to f.delta, 7 of them are protected by
f.mu.Lock()
, but the one at line 173 of file grpc/internal/transport/flowcontrol.go is not protected. In order to avoid potential data race here, I usedefer f.mu.Unlock()
to make sure that all usages of f.delta is in critical section.Buggy code
The last read operation of f.delta happens after
f.mu.Unlock()
:grpc-go/internal/transport/flowcontrol.go
Lines 162 to 174 in 92635fa