Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: move code to a root level xds directory #2950

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Aug 2, 2019

Move code out of balancer/xds.

We will have a root level xds/ directory which will eventually contain
all xDS implementation including balancer, resolver, client etc.

For now, we will have an xds/experimental/ directory where all the code
will live, and an xds/internal/ directory for stuff internal to the xds
package. Once this is deemed stable enough, it will be moved to the
top-level xds/ directory.

Also, moved balancer/internal/wrr to xds/internal/wrr as this code is
only used by xds today.

@easwars
Copy link
Contributor Author

easwars commented Aug 5, 2019

@menghanl Changed the directory structure as per our offline discussion. PTAL.

@easwars
Copy link
Contributor Author

easwars commented Aug 6, 2019

@menghanl
Moved the balancer/internal/wrr package to internal/wrr as discussed offline.

@easwars easwars force-pushed the xds_refactor branch 2 times, most recently from da6237c to eb459af Compare August 7, 2019 20:42
We will have a root level xds/ directory which will eventually contain
all xDS implementation including balancer, resolver, client etc.

The new structure looks something like this:

grpc/
|
+--xds/
    |
    +--internal/
    |  |
    |  +--balancer/
    |     |
    |     +--edsbalancer/
    |     |
    |     +--lrs/
    |     |
    |     +--orca/
    |
    +--experimental/

Users need to import grpc/xds/experimental package to get all xds
functionality, and this will eventually be moved to grpc/xds.

Also, moved grpc/balancer/internal/wrr to grpc/internal/wrr.
@menghanl menghanl changed the title Xds refactor xds: move code to a root level xds/ directory Aug 7, 2019
@menghanl menghanl changed the title xds: move code to a root level xds/ directory xds: move code to a root level xds directory Aug 7, 2019
@easwars easwars merged commit 36ddecc into grpc:master Aug 7, 2019
@easwars easwars deleted the xds_refactor branch August 7, 2019 23:44
@menghanl menghanl added the Type: API Change Breaking API changes (experimental APIs only!) label Aug 8, 2019
@menghanl menghanl added this to the 1.23 Release milestone Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants