Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2client: remove unnecessary allocations for header fields #2925

Merged
merged 1 commit into from
Jul 24, 2019
Merged

http2client: remove unnecessary allocations for header fields #2925

merged 1 commit into from
Jul 24, 2019

Conversation

dzbarsky
Copy link
Contributor

No description provided.

@dzbarsky
Copy link
Contributor Author

@dfawley mind taking a look?

menghanl
menghanl approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@menghanl menghanl changed the title Remove some allocations in http2client header fields http2client: remove unnecessary allocations for header fields Jul 24, 2019
@menghanl menghanl merged commit decb438 into grpc:master Jul 24, 2019
@dfawley dfawley added the Type: Performance Performance improvements (CPU, network, memory, etc) label Jul 25, 2019
@dfawley dfawley added this to the 1.23 Release milestone Jul 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Performance Performance improvements (CPU, network, memory, etc)
Projects
None yet
Milestone
1.23 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@dzbarsky @menghanl @dfawley