Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpclb: enable keepalive #2918

Merged
merged 1 commit into from
Jul 22, 2019
Merged

grpclb: enable keepalive #2918

merged 1 commit into from
Jul 22, 2019

Conversation

menghanl
Copy link
Contributor

So grpclb client will reconnect when the connection is down (e.g. proxy
drops the server side connection but keeps the client side).

@menghanl
grpclb: enable keepalive
6977446 
So grpclb client will reconnect when the connection is down (e.g. proxy
drops the server side connection but keeps the client side).
@menghanl menghanl requested a review from dfawley July 19, 2019 16:40
dfawley
dfawley approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue or spec that recommends these specific numbers? If so it would be great to reference it in this PR & in the code.

@menghanl menghanl merged commit a975db9 into grpc:master Jul 22, 2019
@menghanl menghanl deleted the grpclb_keepalive branch July 22, 2019 19:45
@dfawley dfawley added the Type: Feature New features or improvements in behavior label Jul 25, 2019
@dfawley dfawley added this to the 1.23 Release milestone Jul 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.23 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @dfawley