client: fix canceled vs deadline exceeded double-check logic #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Jul 15, 2019
internal/transport/http2_client.go
Outdated
| // Our deadline was already exceeded, and that was likely the cause of | ||
| // this cancelation. Alter the status code accordingly. | ||
| if d, ok := s.ctx.Deadline(); ok && d.After(time.Now()) { | ||
| if d, ok := s.ctx.Deadline(); ok && d.Before(time.Now()) { |
There was a problem hiding this comment.
I think we want to include if d == now.
There was a problem hiding this comment.
If the current time is the same as the deadline, was the deadline "exceeded"?
I don't think this will matter much either way. Done.
There was a problem hiding this comment.
deadline - now() = timeout. So any timer created is triggering when deadline == now (but yes, it may be delayed). Yes, that matters a lot less than the general fix here.
ejona86
approved these changes
Jul 15, 2019
menghanl
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ejona86