internal: move syscall.Conn wrapper into a separate package #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you're missing a build tag based on travis. Please reassign after fixing. |
dfawley
reviewed
Nov 14, 2018
| * | ||
| */ | ||
|
|
||
| package internal |
credentials/internal/syscallconn.go
Outdated
| rawConn net.Conn | ||
| } | ||
|
|
||
| // WrapSyscallConn tries to wrapper rawConn and newConn into a net.Conn that |
credentials/internal/syscallconn.go
Outdated
| // help here). | ||
| type syscallConn struct { | ||
| net.Conn | ||
| rawConn net.Conn |
There was a problem hiding this comment.
can this be an embedded syscall.Conn instead, and then we don't even need to implement the method manually?
There was a problem hiding this comment.
If you embed the syscall.Conn instead of naming the field, you won't need to define the method at all.
There was a problem hiding this comment.
Hmm, good idea.
But they are all named Conn (net.Conn vs syscall.Conn), and are "duplicate fields"...
dfawley
reviewed
Nov 14, 2018
| @@ -0,0 +1,67 @@ | |||
| // +build !appengine | |||
There was a problem hiding this comment.
"OR Go1.11"? With the other being "AND !Go1.11"?
There was a problem hiding this comment.
Actually, let's save this for a later PR.
dfawley
approved these changes
Nov 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also skip wrapping if
rawConndoesn't implementsyscall.Conn.