-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Go1.6-1.8 #2428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing README changes.
Reviewed 51 of 51 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dfawley)
channelz/service/service_test.go, line 54 at r1 (raw file):
// This behavior will make reflect.DeepEqual fail upon unset time.Time field, // and cause false positive fatal error. // TODO: Go1.7 is no longer supported - does this need a change?
@lyuxuan to take a look.
credentials/credentials.go, line 315 at r1 (raw file):
func init() { cipherSuiteLookup[tls.TLS_RSA_WITH_AES_128_CBC_SHA256] = "TLS_RSA_WITH_AES_128_CBC_SHA256"
Merge these with the map above.
credentials/credentials.go, line 327 at r1 (raw file):
// // If cfg is nil, a new zero tls.Config is returned. func cloneTLSConfig(cfg *tls.Config) *tls.Config {
I think we can just inline this function. Add a TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @menghanl)
channelz/service/service_test.go, line 54 at r1 (raw file):
Previously, menghanl (Menghan Li) wrote…
@lyuxuan to take a look.
Let's follow-up on that in a separate PR.
credentials/credentials.go, line 315 at r1 (raw file):
Previously, menghanl (Menghan Li) wrote…
Merge these with the map above.
Done.
credentials/credentials.go, line 327 at r1 (raw file):
Previously, menghanl (Menghan Li) wrote…
I think we can just inline this function. Add a TODO?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
And change labels to keep this in the release notes. |
It would be great if you would version your install links. Now |
@mitar I don't think |
This change is