channelz: remove init logging #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Oct 11, 2018
internal/channelz/types_nonlinux.go
Outdated
| @@ -35,4 +31,6 @@ type SocketOptionData struct { | |||
| // Getsockopt defines the function to get socket options requested by channelz. | |||
| // It is to be passed to syscall.RawConn.Control(). | |||
| // Windows OS doesn't support Socket Option | |||
| func (s *SocketOptionData) Getsockopt(fd uintptr) {} | |||
| func (s *SocketOptionData) Getsockopt(fd uintptr) { | |||
| grpclog.Infof("Channelz: socket options are not supported on non-linux os and appengine.") | |||
There was a problem hiding this comment.
How often will this be invoked? We should wrap it in a sync.Once if it's frequent enough.
There was a problem hiding this comment.
It will be invoked when user try to get socket option for a socket on a platform that's not supported. I think log it once may make it easy to be overlooked. Or we can do sync.Once(grpc.Warningf(...) to only log once but draw more attention?
dfawley
approved these changes
Oct 12, 2018
menghanl
pushed a commit
that referenced
this pull request
Apr 2, 2019
The same as #2373. Signed-off-by: Yangmin Zhu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2335