Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify newCCResolverWrapper documentation. #2100

Merged
merged 1 commit into from
May 24, 2018
Merged

Conversation

gnoack
Copy link
Contributor

@gnoack gnoack commented May 23, 2018

I think the goroutine does not get started any more (this used to be the case in an earlier version).

I think the goroutine does not get started any more (this used to be the case in an earlier version).
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. LGTM.

Can you please also sign the CLA? Merge is blocked by the CLA check. Thanks!

@gnoack
Copy link
Contributor Author

gnoack commented May 24, 2018

Hmm, the LinuxFoundation page says "You are already authorized to contribute code to this project through your membership with Google." Not sure why this is still red. I'll give it another day or so, in case it's a propagation delay.

@gnoack
Copy link
Contributor Author

gnoack commented May 24, 2018

Ah, it worked :)

@menghanl
Copy link
Contributor

Thanks!

@menghanl menghanl merged commit 1fa3750 into grpc:master May 24, 2018
@menghanl menghanl added the Type: Documentation Documentation or examples label May 24, 2018
@menghanl menghanl added this to the 1.13 Release milestone Jun 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants