grpclb: backoff for RPC call if init handshake was unsucessful #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
changed the title
dfawley
reviewed
May 31, 2018
grpclb_remote_balancer.go
Outdated
| @@ -176,13 +176,13 @@ func (lb *lbBalancer) sendLoadReport(s *balanceLoadClientStream, interval time.D | |||
| } | |||
| } | |||
|
|
|||
| func (lb *lbBalancer) callRemoteBalancer() error { | |||
| func (lb *lbBalancer) callRemoteBalancer() (backoff bool, _ error) { | |||
There was a problem hiding this comment.
Another idea, to avoid the need for this boolean:
Remove lb.readServerList() from this function and call it where this function is called from. Then do:
if err := callRemoteBalancer(); err != nil {
// Do not backoff
continue
}
if err := lb.readServerList(); err != nil {
// Backoff
...
}
There was a problem hiding this comment.
Then the function still needs to return the stream as well.
Will keep the current code.
menghanl
force-pushed
the
grpclb_backoff
branch
2 times, most recently
from
bfbf29b to
88c6170
Compare
dfawley
approved these changes
Jun 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.