ClientConn: Introduce GetStatus method to get the latest connection error #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
May 8, 2018
| @@ -877,6 +887,9 @@ func (cc *ClientConn) removeAddrConn(ac *addrConn, err error) { | |||
| return | |||
| } | |||
| delete(cc.conns, ac) | |||
| if len(cc.conns) == 0 { | |||
| cc.blockingpicker.updateConnectionError(errors.New("no backends returned by resolver")) | |||
There was a problem hiding this comment.
What if the balancer wanted to remove the last addrConn from cc? It will also be zero in that case.
There was a problem hiding this comment.
Isn't this that code path?
| if cc.GetState() != connectivity.TransientFailure { | ||
| return nil | ||
| } | ||
| return status.Errorf(codes.Unavailable, "latest connection error: %v", cc.blockingpicker.connectionError()) |
There was a problem hiding this comment.
What's the advantage of using status error here?
What other error codes will we return?
There was a problem hiding this comment.
It mirrors the Java API. That one returns a status directly, but I thought "error" would be more idiomatic for us.
|
Closing for now until I get a chance to revisit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2031
This may be just a proof of concept, but I think we will need something like this. A few things I noticed:
GetState() == TransientFailureand doing theGetStatus()call, so maybe it's fine?