Documentation: create doc describing grpc-go's log levels and their usages #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakMukhi
approved these changes
May 10, 2018
menghanl
reviewed
May 15, 2018
|
|
||
| Examples: | ||
| - Resolver could not resolve target name. | ||
| - Error received while connecting to a server. |
There was a problem hiding this comment.
TLS makes things tricky again...
What if the connection failed because TLS misconfigure?
There was a problem hiding this comment.
That sounds like a warning to me, what do you think?
lyuxuan
approved these changes
Jun 9, 2018
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is agreed upon, we should take a sweep through all our logging and make sure it is compliant.
related to #2025