Keep retrying in addrConn even on non-temporary errors #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying happens with exponential backoff, so the overhead should be tolerable.
We need this to trigger resolver re-resolve for new addresses.
Permanent errors are in general hard to deal with, and it's not support in other languages.
It's sometimes hard to tell the difference between temporary errors and non-temporary errors. Even for the typical "permanent" TLS handshake errors, it could be caused by a wrong setting on the server side, and a second retry could work.
We still need to way to let the user find out this kind of errors quickly.
With #1855, users should have enough information to decide what to do based on the returned RPC errors.