Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single-entry var blocks #1589

Merged
merged 1 commit into from
Oct 18, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions backoff.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@ import (

// DefaultBackoffConfig uses values specified for backoff in
// https://github.com/grpc/grpc/blob/master/doc/connection-backoff.md.
var (
DefaultBackoffConfig = BackoffConfig{
MaxDelay: 120 * time.Second,
baseDelay: 1.0 * time.Second,
factor: 1.6,
jitter: 0.2,
}
)
var DefaultBackoffConfig = BackoffConfig{
MaxDelay: 120 * time.Second,
baseDelay: 1.0 * time.Second,
factor: 1.6,
jitter: 0.2,
}

// backoffStrategy defines the methodology for backing off after a grpc
// connection failure.
Expand Down
4 changes: 1 addition & 3 deletions benchmark/server/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ import (
"google.golang.org/grpc/grpclog"
)

var (
duration = flag.Int("duration", math.MaxInt32, "The duration in seconds to run the benchmark server")
)
var duration = flag.Int("duration", math.MaxInt32, "The duration in seconds to run the benchmark server")

func main() {
flag.Parse()
Expand Down
4 changes: 1 addition & 3 deletions benchmark/worker/benchmark_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ import (
"google.golang.org/grpc/testdata"
)

var (
caFile = flag.String("ca_file", "", "The file containing the CA root cert file")
)
var caFile = flag.String("ca_file", "", "The file containing the CA root cert file")

type lockingHistogram struct {
mu sync.Mutex
Expand Down
18 changes: 8 additions & 10 deletions codec.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,11 @@ func (protoCodec) String() string {
return "proto"
}

var (
protoBufferPool = &sync.Pool{
New: func() interface{} {
return &cachedProtoBuffer{
Buffer: proto.Buffer{},
lastMarshaledSize: 16,
}
},
}
)
var protoBufferPool = &sync.Pool{
New: func() interface{} {
return &cachedProtoBuffer{
Buffer: proto.Buffer{},
lastMarshaledSize: 16,
}
},
}
14 changes: 5 additions & 9 deletions credentials/credentials.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,8 @@ import (
"golang.org/x/net/context"
)

var (
// alpnProtoStr are the specified application level protocols for gRPC.
alpnProtoStr = []string{"h2"}
)
// alpnProtoStr are the specified application level protocols for gRPC.
var alpnProtoStr = []string{"h2"}

// PerRPCCredentials defines the common interface for the credentials which need to
// attach security information to every RPC (e.g., oauth2).
Expand Down Expand Up @@ -74,11 +72,9 @@ type AuthInfo interface {
AuthType() string
}

var (
// ErrConnDispatched indicates that rawConn has been dispatched out of gRPC
// and the caller should not close rawConn.
ErrConnDispatched = errors.New("credentials: rawConn is dispatched out of gRPC")
)
// ErrConnDispatched indicates that rawConn has been dispatched out of gRPC
// and the caller should not close rawConn.
var ErrConnDispatched = errors.New("credentials: rawConn is dispatched out of gRPC")

// TransportCredentials defines the common interface for all the live gRPC wire
// protocols and supported transport security protocols (e.g., TLS, SSL).
Expand Down
10 changes: 4 additions & 6 deletions examples/route_guide/mock_routeguide/rg_mock_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,10 @@ import (
rgpb "google.golang.org/grpc/examples/route_guide/routeguide"
)

var (
msg = &rgpb.RouteNote{
Location: &rgpb.Point{Latitude: 17, Longitude: 29},
Message: "Taxi-cab",
}
)
var msg = &rgpb.RouteNote{
Location: &rgpb.Point{Latitude: 17, Longitude: 29},
Message: "Taxi-cab",
}

func TestRouteChat(t *testing.T) {
ctrl := gomock.NewController(t)
Expand Down
10 changes: 4 additions & 6 deletions interop/test_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -394,12 +394,10 @@ func DoPerRPCCreds(tc testpb.TestServiceClient, serviceAccountKeyFile, oauthScop
}
}

var (
testMetadata = metadata.MD{
"key1": []string{"value1"},
"key2": []string{"value2"},
}
)
var testMetadata = metadata.MD{
"key1": []string{"value1"},
"key2": []string{"value2"},
}

// DoCancelAfterBegin cancels the RPC after metadata has been sent but before payloads are sent.
func DoCancelAfterBegin(tc testpb.TestServiceClient, args ...grpc.CallOption) {
Expand Down
4 changes: 1 addition & 3 deletions resolver/dns/dns_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ const (
txtAttribute = "grpc_config="
)

var (
errMissingAddr = errors.New("missing address")
)
var errMissingAddr = errors.New("missing address")

// NewBuilder creates a dnsBuilder which is used to factory DNS resolvers.
func NewBuilder() resolver.Builder {
Expand Down
26 changes: 11 additions & 15 deletions resolver/dns/dns_resolver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,8 @@ func div(b []byte) []string {
// resolver functionality, with scfs as the input and scs used for validation of
// the output. For scfs[3], it corresponds to empty service config, since there
// isn't a matched choice.
var (
scfs = []string{
`[
var scfs = []string{
`[
{
"clientLanguage": [
"CPP",
Expand Down Expand Up @@ -242,7 +241,7 @@ var (
}
}
]`,
`[
`[
{
"clientLanguage": [
"CPP",
Expand Down Expand Up @@ -335,7 +334,7 @@ var (
}
}
]`,
`[
`[
{
"clientLanguage": [
"CPP",
Expand Down Expand Up @@ -434,7 +433,7 @@ var (
}
}
]`,
`[
`[
{
"clientLanguage": [
"CPP",
Expand Down Expand Up @@ -489,13 +488,11 @@ var (
}
}
]`,
}
)
}

// scs contains an array of service config string in JSON format.
var (
scs = []string{
`{
var scs = []string{
`{
"methodConfig": [
{
"name": [
Expand All @@ -508,7 +505,7 @@ var (
}
]
}`,
`{
`{
"methodConfig": [
{
"name": [
Expand All @@ -524,7 +521,7 @@ var (
}
]
}`,
`{
`{
"loadBalancingPolicy": "round_robin",
"methodConfig": [
{
Expand All @@ -546,8 +543,7 @@ var (
}
]
}`,
}
)
}

// scLookupTbl is a set, which contains targets that have service config. Target
// not in this set should not have service config.
Expand Down
4 changes: 1 addition & 3 deletions resolver/dns/go17_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ import (
"golang.org/x/net/context"
)

var (
errForInvalidTarget = fmt.Errorf("invalid target address [2001:db8:a0b:12f0::1, error info: missing ']' in address [2001:db8:a0b:12f0::1:443")
)
var errForInvalidTarget = fmt.Errorf("invalid target address [2001:db8:a0b:12f0::1, error info: missing ']' in address [2001:db8:a0b:12f0::1:443")

func replaceNetFunc() func() {
oldLookupHost := lookupHost
Expand Down
4 changes: 1 addition & 3 deletions resolver/dns/go18_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ import (
"net"
)

var (
errForInvalidTarget = fmt.Errorf("invalid target address [2001:db8:a0b:12f0::1, error info: address [2001:db8:a0b:12f0::1:443: missing ']' in address")
)
var errForInvalidTarget = fmt.Errorf("invalid target address [2001:db8:a0b:12f0::1, error info: address [2001:db8:a0b:12f0::1:443: missing ']' in address")

func replaceNetFunc() func() {
oldLookupHost := lookupHost
Expand Down
8 changes: 3 additions & 5 deletions server.go
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,9 @@ func (s *Server) GetServiceInfo() map[string]ServiceInfo {
return ret
}

var (
// ErrServerStopped indicates that the operation is now illegal because of
// the server being stopped.
ErrServerStopped = errors.New("grpc: the server has been stopped")
)
// ErrServerStopped indicates that the operation is now illegal because of
// the server being stopped.
var ErrServerStopped = errors.New("grpc: the server has been stopped")

func (s *Server) useTransportAuthenticator(rawConn net.Conn) (net.Conn, credentials.AuthInfo, error) {
if s.opts.creds == nil {
Expand Down
9 changes: 3 additions & 6 deletions transport/bdp_estimator.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,9 @@ const (
gamma = 2
)

var (
// Adding arbitrary data to ping so that its ack can be
// identified.
// Easter-egg: what does the ping message say?
bdpPing = &ping{data: [8]byte{2, 4, 16, 16, 9, 14, 7, 7}}
)
// Adding arbitrary data to ping so that its ack can be identified.
// Easter-egg: what does the ping message say?
var bdpPing = &ping{data: [8]byte{2, 4, 16, 16, 9, 14, 7, 7}}

type bdpEstimator struct {
// sentAt is the time when the ping was sent.
Expand Down