Don't fatal on encoding errors #1025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamird
suggested changes
Dec 19, 2016
| @@ -261,28 +261,27 @@ func encode(c Codec, msg interface{}, cp Compressor, cbuf *bytes.Buffer, outPayl | |||
| var ( | |||
| b []byte | |||
| length uint | |||
| err error | |||
There was a problem hiding this comment.
all the changes in this file are unnecessary (and the new code is worse, since it increases the scope of err needlessly).
| // the optimal option. | ||
| grpclog.Fatalf("grpc: Server failed to encode response %v", err) | ||
| err = fmt.Errorf("grpc: Server failed to encode response %v", err) | ||
| grpclog.Println(err) |
There was a problem hiding this comment.
can this just return the error directly instead of also logging it?
menghanl
force-pushed
the
marshal_nil_error
branch
from
b46ee02 to
3a8c6ec
Compare
dfawley
reviewed
May 19, 2017
| // faulty stream locally and remotely (Other streams can keep going). Find | ||
| // the optimal option. | ||
| grpclog.Fatalf("grpc: Server failed to encode response %v", err) | ||
| err = fmt.Errorf("grpc: Server failed to encode response %v", err) |
There was a problem hiding this comment.
encode() should return a status error instead, and then we can just return it.
|
Replaced by #1251 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #532
cc @songshine @ashishgandhi