-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google.golang.org/grpc v1.66.1 is missing a retraction #7618
Comments
Sorry for the trouble. I have re-added the tag for 1.66.1. There is nothing in this release, but v1.66.2 should be released later today with some bug fixes. |
Thank you! 🙏 Would be great if |
@mx-psi - I don't believe it's important to do a retraction here, since the v1.66.1 version is "fine" -- it reflects the proper version number in the user agent string, and it contains no regressions or unintended code. It is just the exact same as v1.66.0 except for the user agent string. |
Thanks for clarifying 👍 that makes sense, I agree it can be kept as is then :) |
The v1.66.1 tag is available on the pkg.go.dev docs domain and the official Go proxy (download here, sumdb entry here), but it looks like the tag has been removed from this repository.
This breaks build for anyone that is not using the official Go proxy and is building a module that has v1.66.1 on their dependency tree, it breaks automatic dependency tools like Dependabot and it breaks even people pinning commits if their pseudoversion has v1.66.1 as the base version. Would it be possible for this tag to be re-added to the repository to avoid this breakage? Thanks!
Similar issues on other projects for context:
As mentioned on this comment #7608 (comment) the correct approach is to
retract
the version but keep the tag available.The text was updated successfully, but these errors were encountered: