Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the v1.66.1 release notes? #7608

Closed
rootulp opened this issue Sep 10, 2024 · 3 comments
Closed

Where are the v1.66.1 release notes? #7608

rootulp opened this issue Sep 10, 2024 · 3 comments

Comments

@rootulp
Copy link

rootulp commented Sep 10, 2024

Context

I'm trying to review this PR: celestiaorg/celestia-app#3852

Problem

I don't know what is new in v1.66.1 because I can't find release notes for it. The last release I can see is https://github.com/grpc/grpc-go/releases/tag/v1.66.0

The diff seems insignificant to me: v1.66.0...v1.66.1 so maybe it was intentional to not create an official release for it?

Proposal

  1. Create a release for v1.66.1 with release notes
@purnesh42H
Copy link
Contributor

yeah 1.66.1 is a patch release we are planning. It hasn't been published yet. I have deleted the tag for now. Will re-publish once everything is ready.

@pellared
Copy link
Contributor

pellared commented Sep 10, 2024

@purnesh42H, are you aware that it has been already published to Google's Go modules proxy?
See: https://pkg.go.dev/google.golang.org/[email protected]

Shouldn't this version be retracted and v1.66.2 published instead?

References:

I think you should consider reopening the issue or creating a separate one for retraction of v1.66.1.

@purnesh42H
Copy link
Contributor

purnesh42H commented Sep 12, 2024

1.66.2 is published https://github.com/grpc/grpc-go/releases/tag/v1.66.2 and we don't retraction for 1.66.1 since it is just the exact same as v1.66.0 except for the user agent string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants