Skip to content

Commit

Permalink
Update deprecation note
Browse files Browse the repository at this point in the history
Tell people to replace Dial + WithTimeout by DialContext + context.WithTimeout.
  • Loading branch information
ensonic committed Dec 12, 2019
1 parent 4323b78 commit 0d2b2cd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dialoptions.go
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,8 @@ func WithCredentialsBundle(b credentials.Bundle) DialOption {
// WithTimeout returns a DialOption that configures a timeout for dialing a
// ClientConn initially. This is valid if and only if WithBlock() is present.
//
// Deprecated: use DialContext and context.WithTimeout instead. Will be
// supported throughout 1.x.
// Deprecated: use DialContext instead of Dial and context.WithTimeout
// instead. Will be supported throughout 1.x.
func WithTimeout(d time.Duration) DialOption {
return newFuncDialOption(func(o *dialOptions) {
o.timeout = d
Expand Down

0 comments on commit 0d2b2cd

Please sign in to comment.