Avoid double lookup in dictionary

grpc · Oct 21, 2024 · 97583df · 97583df
1 parent 8688d5c
commit 97583df
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/Grpc.AspNetCore.Server/Internal/GrpcProtocolHelpers.cs b/src/Grpc.AspNetCore.Server/Internal/GrpcProtocolHelpers.cs
@@ -18,6 +18,7 @@
 
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
+using System.Runtime.InteropServices;
 using System.Security.Cryptography.X509Certificates;
 using System.Text;
 using Grpc.Core;
@@ -108,7 +109,7 @@ public static byte[] ParseBinaryHeader(string base64)
         switch (base64.Length % 4)
         {
             case 0:
-                // base64 has the required padding 
+                // base64 has the required padding
                 decodable = base64;
                 break;
             case 2:
@@ -208,11 +209,8 @@ public static AuthContext CreateAuthContext(X509Certificate2 clientCertificate)
 
         static void AddProperty(Dictionary<string, List<AuthProperty>> properties, string name, string value)
         {
-            if (!properties.TryGetValue(name, out var values))
-            {
-                values = new List<AuthProperty>();
-                properties[name] = values;
-            }
+            ref var values = ref CollectionsMarshal.GetValueRefOrAddDefault(properties, name, out _);
+            values ??= [];
 
             values.Add(AuthProperty.Create(name, Encoding.UTF8.GetBytes(value)));
         }