newline between JSON messages #931
Conversation
It needs to use the same text, so that the I've updated to make sure these are consistent (per what I think you were recommending). PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
- Coverage 53.5% 53.49% -0.01%
==========================================
Files 40 40
Lines 3957 3961 +4
==========================================
+ Hits 2117 2119 +2
- Misses 1642 1643 +1
- Partials 198 199 +1
Continue to review full report at Codecov.
|
|
Thanks for your contribution! |
| } | ||
| // mimic json.Encoder by adding a newline (makes output | ||
| // easier to read when it contains multiple encoded items) | ||
| _, err := w.Write(j.Delimiter()) |
There was a problem hiding this comment.
In etcd this may be written to different HTTP chunk, right? As far as I know, the protocol must guarantee that 1 chunk = 1 message (JSON).
I don't understand go, but I have the code that triggers that on high load. I mean, sometimes newline is seen as a separate HTTP chunk.
moreover, comment here state that newline is only for easy debugging. May I rely on it safely ? if yes, please update the documentation. If no, please state it. And also please write something about message=chunk atomicity.
There was a problem hiding this comment.
Moreover. What also stops from gluing two messages in one HTTP chunk?
What I propose: is to document that every message is separated strictly by one newline. In that case, there is possible to write stable and simple stream parsing that does not rely on HTTP chunk boundary, and which also does not use streaming JSON parser to detect end of a message. If you accept that, you should document that users must not rely on chunk boundaries in order to split stream to messages.
There was a problem hiding this comment.
Could you please raise a separate issue detailing your concerns? I don't think this change covers the behaviour you're asking about.
* newline between JSON messages from JSONPb.Encode * use j.Delimiter() * fix jsonpb tests
This updates
JSONPbso that its encoder function delimits output messages with a newline, just likeEncoderin"encoding/json"does.