Use proto gen swagger with protos from external repository #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @achew22, any comments? |
|
Looks like the bazel tests failed for unrelated reasons, but the bazel formatter also failed. Could you try running the formatter please? |
elenadeneva92
force-pushed
the
swagger-external-proto
branch
from
c115f97 to
b1dffd8
Compare
Currently the protoc_gen_swagger doesn't work with protos from external repositories. The bazel rule because the swagger.json file is not stored at the expected place. Example if the rule for the proto @remote//proto:action_proto is passed to the protoc_gen_swagger, the action.swagger.json file is written to proto/action.swagger.json and is expected to be at the same place as the proto external/remote/proto/action.swagger.json.
elenadeneva92
force-pushed
the
swagger-external-proto
branch
from
b1dffd8 to
5a0c4ce
Compare
|
@johanbrandhorst Done :) |
|
Sorry, this totally fell between the chairs. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the protoc_gen_swagger doesn't work with protos from external repositories.
The the swagger.json file is not stored at the expected place.
Example:
protoc_gen_swagger(
name = "action_swagger",
proto = "@remote//proto:action_proto"
)
fails because the action.swagger.json file is written to proto/action.swagger.json and
is expected to be at the same place as the proto external/remote/proto/action.swagger.json. Bazel can't find the generated rule and fails.