-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #782 Cannot return HTTP header using "Grpc-Metadata-" prefix #783
fix #782 Cannot return HTTP header using "Grpc-Metadata-" prefix #783
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@joelurraco it seems you've committed with an email/username that is different from the one you're using to open this PR. |
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
==========================================
+ Coverage 53.37% 53.39% +0.01%
==========================================
Files 30 30
Lines 3361 3362 +1
==========================================
+ Hits 1794 1795 +1
Misses 1392 1392
Partials 175 175
Continue to review full report at Codecov.
|
@johanbrandhorst yes, but I've just signed the CLA with both accounts |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Not much I can do about the Google bot I'm afraid - would you mind force pushing a new commit or opening a new PR with the other account? |
Superceded by #784 |
No description provided.