Avoid timing issues in the integration tests #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugui
changed the title
|
Still failing when the grpc server is not ready. Need to check health of it too. |
yugui
changed the title
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 58.88% 59.02% +0.14%
==========================================
Files 30 30
Lines 2853 2858 +5
==========================================
+ Hits 1680 1687 +7
+ Misses 1010 1008 -2
Partials 163 163
Continue to review full report at Codecov.
|
yugui
force-pushed
the
fix/integration-timing
branch
from
e1d8b8c to
d832094
Compare
achew22
approved these changes
Apr 27, 2018
examples/integration/main_test.go
Outdated
| return err | ||
| case <-t.C: | ||
| return err | ||
| case <-s.C: |
There was a problem hiding this comment.
Use time.After to produce your timeout
yugui
force-pushed
the
fix/integration-timing
branch
from
d832094 to
3d1e328
Compare
Wait for the gateway server to get ready. #609 (comment)
yugui
force-pushed
the
fix/integration-timing
branch
from
3d1e328 to
63d6aa1
Compare
achew22
approved these changes
Apr 27, 2018
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* Avoid timing issues in the integration tests Wait for the gateway server to get ready. grpc-ecosystem#609 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the gateway server to get ready.
#609 (comment)