-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-swagger/genswagger: add PATCH support #228
Conversation
CLA should be good to go (https://golang.org/CONTRIBUTORS#L340) |
Thanks so much for sending your PR in. Do you think you could update the example protos to include a "PATCH" and regenerate the generated files? I think "make examples" is all you need to do for that. Thanks! I look forward to having patch support. |
Yeah I think I can do it tomorrow, feel free to ping me if I forget 😄 |
@ericlagergren ping 😉 |
@ericlagergren thank you for your contribution - can you rebase and re-gen examples for this please? |
@ericlagergren I think you are running a different version of swagger-codegen -- this project currently relies on 2.1.6 |
I think you're right. I used the latest swagger-codegen release, whatever version it is. I thought the massive amount of changes looked weird, but I didn't have time to throughly debug it today. I'll revert and re-run it with 2.16 either tonight or tomorrow morning. |
ping @ericlagergren |
Fixes: #211