-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-openapiv2: Fix so that FieldMasks descriptions are correctly generated #1558
protoc-gen-openapiv2: Fix so that FieldMasks descriptions are correctly generated #1558
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for your contribution! |
References to other Issues or PRs
Fixes #1556
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
Added
google.protobuf.FieldMask
as a well-known-type inprotoc-gen-openapiv2
package so that fields of this type are generated with the correct description in Swagger definitions.Other comments
This also had some other side effects, which I'm not sure are considered breaking changes.
FieldMask
fields in the Swagger definition will no longer be suffixed with.paths
protobufFieldMask
type definition will no longer be added to the Swagger definition