Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick #1502 #1509

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Cherrypick #1502 #1509

merged 1 commit into from
Jul 7, 2020

Conversation

yugui
Copy link
Member

@yugui yugui commented Jul 7, 2020

Cherry-pick #1502

@yugui
Corrects an invalid test (#1502)
0022d96 
Fixes #1501.

The expectations in the test was implemented wrong. But the wrong test
input has been hiding the wrong expectation, as explained in #1501.
@yugui yugui requested a review from johanbrandhorst July 7, 2020 11:19
@johanbrandhorst johanbrandhorst merged commit 1ce9f28 into v2 Jul 7, 2020
@johanbrandhorst johanbrandhorst deleted the cherrypick/1502 branch July 7, 2020 11:25
@johanbrandhorst
Copy link
Collaborator

Thanks again for the fix 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yugui @johanbrandhorst @googlebot