Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rpc comment generation against allow_merge (v2) #1446

Merged

Conversation

kentdotn
Copy link
Contributor

@kentdotn kentdotn commented Jun 7, 2020

References to other Issues or PRs

Same as #1445 but for v2

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

See #1445 for details.

@kentdotn
Copy link
Contributor Author

kentdotn commented Jun 7, 2020

Hmm, I don't know what causes such diff in BUILD.bazel.
Should I do something?

@johanbrandhorst
Copy link
Collaborator

Hmm, I don't know what causes such diff in BUILD.bazel.
Should I do something?

I'm looking into it

@johanbrandhorst johanbrandhorst force-pushed the fix-comment-gen-allow-merge branch from 949bc19 to 2cd3bca Compare June 7, 2020 15:57
@codecov-commenter
Copy link

Codecov Report

Merging #1446 into v2 will increase coverage by 0.05%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #1446      +/-   ##
==========================================
+ Coverage   59.00%   59.05%   +0.05%     
==========================================
  Files          32       32              
  Lines        3898     3903       +5     
==========================================
+ Hits         2300     2305       +5     
  Misses       1344     1344              
  Partials      254      254              
Impacted Files Coverage Δ
...toc-gen-openapiv2/internal/genopenapi/generator.go 9.09% <0.00%> (ø)
...otoc-gen-openapiv2/internal/genopenapi/template.go 58.04% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9d04e...2cd3bca. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 34394bf into grpc-ecosystem:v2 Jun 7, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@kentdotn kentdotn deleted the fix-comment-gen-allow-merge branch June 7, 2020 16:10
@kentdotn
Copy link
Contributor Author

kentdotn commented Jun 7, 2020

Thanks!

@ivucica ivucica mentioned this pull request Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants