protoc-gen-openapiv2: Fix message recursion detection (v2) #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes a bug introduced during 9e25b2b which introduced recursion detection within messages. Briefly, the nature of the bug was that references to messages not in the current recursion traversal were remaining in the map used to track those occurrences. - Includes a test case outlining the edge case that prompted this fix.
doyleish
changed the title
Codecov Report
@@ Coverage Diff @@
## v2 #1439 +/- ##
==========================================
+ Coverage 58.97% 59.00% +0.03%
==========================================
Files 32 32
Lines 3895 3898 +3
==========================================
+ Hits 2297 2300 +3
Misses 1344 1344
Partials 254 254
Continue to review full report at Codecov.
|
johanbrandhorst
approved these changes
Jun 4, 2020
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked + merged from #1437
detection within messages. Briefly, the nature of the bug was that
references to messages not in the current recursion traversal were
remaining in the map used to track those occurrences.
References to other Issues or PRs
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
Other comments