Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openapi protobuf documentation examples #1429

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Add openapi protobuf documentation examples #1429

merged 1 commit into from
Jun 2, 2020

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented Jun 1, 2020

Add some examples of openapi protobuf annotations.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #1429 into v2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #1429   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files          32       32           
  Lines        3895     3895           
=======================================
  Hits         2297     2297           
  Misses       1344     1344           
  Partials      254      254           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19541c...3731b9a. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, with the exception that we need to use the new package name in the annotations. Thanks!

protoc-gen-openapiv2/options/openapiv2.proto Outdated Show resolved Hide resolved
@johanbrandhorst johanbrandhorst merged commit 37d2faa into grpc-ecosystem:v2 Jun 2, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@bvwells bvwells deleted the v2 branch June 2, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants