-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding the primitive type of fields #1003
Allow overriding the primitive type of fields #1003
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Do I need to generate everything with bazel to make this pass CI? |
Yes, but there's a handy oneliner in CONTRIBUTING.md |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
==========================================
- Coverage 53.45% 53.42% -0.03%
==========================================
Files 40 40
Lines 4028 4030 +2
==========================================
Hits 2153 2153
- Misses 1676 1677 +1
- Partials 199 200 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution and careful and attentive replies to my questions, great work!
* Allow overriding the primitive type of fields * Updated generated files and added a separate example for type override * Fixed formatting * Made logic for type override a little bit more forgiving * Added additional files it needs to pass tests
Allows you to specify a custom type in case you've altered the default json handling behavior.