Automatically add verifiedDomain when possible to new Cloud orgs #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-997-bttf has been deployed with errors. |
tinahollygb
reviewed
Feb 14, 2023
packages/back-end/src/routers/organizations/organizations.controller.ts
Outdated
Show resolved
Hide resolved
tinahollygb
reviewed
Feb 14, 2023
|
I left some comments. It might also be helpful to provide a PR description so when we come back to this in the future, we understand some context. It looks like you may have forgotten to add some PR details and the default PR template is populated. |
|
Thanks for the feedback (and sorry about the missing PR description) @tinahollygb! I originally opened this PR as a hotfix, then realized it wasn't urgent and had a few more changes than anticipated. Forgot to add a description. |
tinahollygb
previously approved these changes
Feb 15, 2023
jdorn
reviewed
Feb 16, 2023
packages/back-end/src/routers/organizations/organizations.controller.ts
Outdated
Show resolved
Hide resolved
packages/back-end/src/routers/organizations/organizations.controller.ts
Outdated
Show resolved
Hide resolved
jdorn
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fast-follow to a previous PR which allows new Cloud SSO users to join existing verified orgs:
#979
This change does a few things: