Always show 'Download Notebook' button, but disable it when not available #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it if the organization is not set up for it yet, and also add tooltip with brief guidance on what this button does and how to get set up.
mknowlton89
requested review from
jdorn,
Auz,
bryce-fitzsimons,
bttf and
tinahollygb
lukesonnet
pushed a commit
that referenced
this pull request
Dec 12, 2022
…able (#799) * Refactor the 'Download Notebook' button to always display, but disable it if the organization is not set up for it yet, and also add tooltip with brief guidance on what this button does and how to get set up.
lukesonnet
pushed a commit
that referenced
this pull request
Dec 12, 2022
…able (#799) * Refactor the 'Download Notebook' button to always display, but disable it if the organization is not set up for it yet, and also add tooltip with brief guidance on what this button does and how to get set up.
lukesonnet
pushed a commit
that referenced
this pull request
Dec 12, 2022
…able (#799) * Refactor the 'Download Notebook' button to always display, but disable it if the organization is not set up for it yet, and also add tooltip with brief guidance on what this button does and how to get set up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Description of Feature
On experiment results, we currently hide the Download Notebook option in the MoreMenu dropdown by default. It's only enabled if the user defines a Jupyter Query Runner for their data source.
This is a really cool feature that most users don't know about. Instead of hiding it, we can still show the option, but grayed out with a tooltip explaining how to enable it.
Dependencies
N/A
Testing
Screenshots