Remove pip from pyproject.toml, add docs for pytest in CONTRIBUTING #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
kelvanb97
reviewed
Sep 13, 2022
Auz
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
pipfrom pyproject.tomlRemoves the version requirement for pip. This helps in cases where a machine has multiple versions of Python and pip and poetry does not use the right version. This can cause
yarn setupto fail at the gbstats setup stage.Add docs for pytest in CONTRIBUTING
Adding a note to activate the poetry env before attempting to run
yarn testfrom the root. Unless the user has pytest installed globally, the execution ofyarn testwould fail.Initially I had added it to the npm
testscript but this caused CI to fail due to poetry not being installed.